add CPP standard CI workflow with cppcheck support#169
Merged
yannS2016 merged 4 commits intopcdshub:masterfrom Apr 6, 2026
Merged
add CPP standard CI workflow with cppcheck support#169yannS2016 merged 4 commits intopcdshub:masterfrom
yannS2016 merged 4 commits intopcdshub:masterfrom
Conversation
Add reusable cpp-standard.yml workflow for C++ projects, mirroring the TwinCAT standard workflow pattern. Add `install-cppcheck` boolean input (default: false) to pre-commit.yml so C++ workflows can ensure cppcheck is available on the runner before running pre-commit hooks.
ZLLentz
reviewed
Apr 1, 2026
Member
There was a problem hiding this comment.
This is a good addition to the central workflows
One consideration: in pre-commit.yml, should this be a more generic install step instead?
Some of the other workflows have a system-packages input.
pcds-ci-helpers/.github/workflows/python-conda-test.yml
Lines 114 to 118 in bcaf685
added 2 commits
April 4, 2026 08:03
Replaced the C++-specific `install-cppcheck` boolean input with a generic `system-packages` string input in pre-commit.yml.Updated cpp-standard.yml to pass `system-packages: "cppcheck"` accordingly.
tangkong
approved these changes
Apr 6, 2026
Contributor
tangkong
left a comment
tangkong
left a comment
There was a problem hiding this comment.
I like this as well. This makes our pre-commit setups more flexible across the board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add reusable cpp-standard.yml workflow for C++ projects, mirroring the TwinCAT standard workflow pattern. Add
install-cppcheckboolean input (default: false) to pre-commit.yml so C++ workflows can ensure cppcheck is available on the runner before running pre-commit hooks.